----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65111/#review195969 -----------------------------------------------------------
Seems like we need http vs driver based tests, and also need to test the failover case? src/tests/slave_tests.cpp Lines 4422-4425 (patched) <https://reviews.apache.org/r/65111/#comment275435> Any reason to test command vs custom executor? Seems like they both behave the same here? Seems we care more about HTTP vs driver-based? src/tests/slave_tests.cpp Lines 4527-4529 (patched) <https://reviews.apache.org/r/65111/#comment275436> Seems we also need the failover case tested? - Benjamin Mahler On Jan. 12, 2018, 2:34 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65111/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 2:34 a.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-8411 > https://issues.apache.org/jira/browse/MESOS-8411 > > > Repository: mesos > > > Description > ------- > > This test verifies that the executor is shutdown if all of its > initial tasks could not be delivered, even after the executor has been > registered. See MESOS-8411. > > > Diffs > ----- > > src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 > src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908 > src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 > > > Diff: https://reviews.apache.org/r/65111/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
