----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/#review196071 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On Jan. 10, 2018, 4:37 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63423/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 4:37 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8140 > https://issues.apache.org/jira/browse/MESOS-8140 > > > Repository: mesos > > > Description > ------- > > Since the executor may run in the smae container and under > the same credential as the user task, we should clear the > `MESOS_EXECUTOR_AUTHENTICATION_TOKEN` environment variable > once we sample it. > > > Diffs > ----- > > src/executor/executor.cpp 1c972d92984a15d12466e3dd229b16fa60e21ebb > > > Diff: https://reviews.apache.org/r/63423/diff/3/ > > > Testing > ------- > > make check (Fedora 26) > > Manual inspection of child process metadata. > > > Thanks, > > James Peach > >
