> On Jan. 24, 2018, 1:56 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/benchmarks.cpp > > Line 677 (original), 677 (patched) > > <https://reviews.apache.org/r/65326/diff/1/?file=1946064#file1946064line677> > > > > We do not seem to depend on this being a `size_t`, so I'd suggest to > > adjust the type here instead of casting below.
I'm fine with that. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65326/#review196171 ----------------------------------------------------------- On Jan. 24, 2018, 1:48 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65326/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 1:48 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > A "possible loss of data" warning was introduced because `process.run()` > implicitly converts to an `int`. Since we have a finite set, we can > ignore this warning and so silence it with a `static_cast`. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp > 10fd492951fb1133d057eb3576f93a5f10e178f3 > > > Diff: https://reviews.apache.org/r/65326/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
