----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65324/#review196175 -----------------------------------------------------------
Do we really want to make Mesos aware of DC/OS's adminrouter and its routes? I think a cleaner approach would be to make it easier for a javascript module or file that overrides the URL generation. configure.ac Lines 297 (patched) <https://reviews.apache.org/r/65324/#comment275703> `adminrouter` is a DC/OS concept. We might want to say "allow accessing the web UI via a reverse proxy"? I'd probably also rename the flag. - Gaston Kleiman On Jan. 24, 2018, 1:40 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65324/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 1:40 p.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > configure.ac b48c80db4d01bf975168398865a12b700bd3d33c > src/webui/master/static/js/controllers.js > 59665869dbea77c00740e42f2590473181dfe2fe > > > Diff: https://reviews.apache.org/r/65324/diff/1/ > > > Testing > ------- > > > Thanks, > > Till Toenshoff > >
