----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65189/#review196221 -----------------------------------------------------------
support/apply-reviews.py Lines 274-275 (patched) <https://reviews.apache.org/r/65189/#comment275774> Manually quoting the string and escaping newlines is insufficient. We also need to be able to handle e.g., strings containing literal `'` or `"` or other characters requiring escaping. - Benjamin Bannier On Jan. 22, 2018, 2:58 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65189/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 2:58 p.m.) > > > Review request for mesos, Armand Grillet and Kevin Klues. > > > Bugs: MESOS-8447 > https://issues.apache.org/jira/browse/MESOS-8447 > > > Repository: mesos > > > Description > ------- > > This patch adds a shell command to create a file containing the commit > message for dry-run mode. To minimize platform differences we use > `printf` instead of `echo`. We output the message on a single line > for compactness. > > > Diffs > ----- > > support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 > > > Diff: https://reviews.apache.org/r/65189/diff/2/ > > > Testing > ------- > > Redirected output of `apply-reviews.py --dry-run` to a file and successfully > applied its output with `sh`. > > > Thanks, > > Benjamin Bannier > >
