-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 6:47 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Summary (updated)
-----------------
Updated libprocess routing to treat trailing '/' as insignificant.
Bugs: MESOS-5333
https://issues.apache.org/jira/browse/MESOS-5333
Repository: mesos
Description (updated)
-------
Prior to this patch, adding a trailing '/' to a valid URL path, e.g.,
"/state/", yielded a 404 response. This patch ensures that two URLs
which differ only in trailing '/' produce the same result.
This is achieved by (1) trimming a trailing '/' when processing a
request and (2) disallowing `route()` calls from using `/`.
Diffs
-----
3rdparty/libprocess/src/process.cpp 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad
3rdparty/libprocess/src/tests/http_tests.cpp
f79d366baecc73e6b14df593a906264f5fd1d72b
Diff: https://reviews.apache.org/r/64574/diff/2/
Testing
-------
Ensured the modified test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.
Thanks,
Alexander Rukletsov