----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65061/#review196282 -----------------------------------------------------------
src/tests/agent_resource_provider_config_api_tests.cpp Line 222 (original), 225 (patched) <https://reviews.apache.org/r/65061/#comment275833> s/agentFlags/slaveFlags/g for consistency src/tests/agent_resource_provider_config_api_tests.cpp Lines 257-263 (original), 260-271 (patched) <https://reviews.apache.org/r/65061/#comment275834> If you make this filter for the max duration as you did in other patches, would it be possible to make the `.WillRepeatedly` call a `.WillOnce` instead? Here and below. src/tests/agent_resource_provider_config_api_tests.cpp Lines 462-463 (patched) <https://reviews.apache.org/r/65061/#comment275835> If you decline offers with only agent resources for a long duration, could you get rid of this? - Greg Mann On Jan. 10, 2018, 3:05 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65061/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 3:05 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8426 > https://issues.apache.org/jira/browse/MESOS-8426 > > > Repository: mesos > > > Description > ------- > > Speeded up tests for resource provider config agent API. > > > Diffs > ----- > > src/tests/agent_resource_provider_config_api_tests.cpp > 7cbee5cceef2963b736f3e6ce3f52fcf0b3c029c > > > Diff: https://reviews.apache.org/r/65061/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
