----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65409/#review196472 -----------------------------------------------------------
Ship it! Ship It! - Gaston Kleiman On Jan. 29, 2018, 12:41 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65409/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 12:41 p.m.) > > > Review request for mesos, Akash Gupta, Gaston Kleiman, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6713 > https://issues.apache.org/jira/browse/MESOS-6713 > > > Repository: mesos > > > Description > ------- > > Because it is not possible to delete a file (or a folder recursively) > with open handles on Windows, we have to explicitly `reset()` the agent > before removing the framework meta directory. Otherwise, the task status > update manager will be destructed too late, and so an open handle for > `task.updates` will cause the `os::rmdir` to fail. > > This is safe because we previously destructed the agent anyway, just > later in the test when it was reassigned. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f > > > Diff: https://reviews.apache.org/r/65409/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
