----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65377/#review196477 -----------------------------------------------------------
Fix it, then Ship it! src/slave/state.cpp Line 90 (original), 90 (patched) <https://reviews.apache.org/r/65377/#comment276138> How about adding a `CHECK(!read.isNone())` afterward? Ditto below for all `state::read<string>()`. - Chun-Hung Hsiao On Jan. 29, 2018, 7:55 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65377/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 7:55 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jie Yu. > > > Bugs: MESOS-8481 > https://issues.apache.org/jira/browse/MESOS-8481 > > > Repository: mesos > > > Description > ------- > > Due to the issue of empty files that can arise from using `rename` > without `fsync` (see commit 3763476), we return `None` to indicate > an empty file. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 44cf9b211f82100b544c1d70e6ad5d6e8db7dec7 > src/slave/containerizer/mesos/paths.cpp > 186048f159d6ce20d9c5dc65c00012eb5911520b > src/slave/state.hpp dcab4434a0d82efec33f55a1037c892d0a7e9d55 > src/slave/state.cpp 41c12f61520b2e769e3a1226bf0a767f779c2a75 > > > Diff: https://reviews.apache.org/r/65377/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
