----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65391/#review196529 -----------------------------------------------------------
Ship it! Ship It! - James DeFelice On Jan. 30, 2018, 12:05 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65391/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 12:05 a.m.) > > > Review request for mesos, Avinash sridharan, James DeFelice, and Qian Zhang. > > > Bugs: MESOS-7605 > https://issues.apache.org/jira/browse/MESOS-7605 > > > Repository: mesos > > > Description > ------- > > Added a new UTS namespace isolator that can be used to > guarantee that a task gets a UTS namespace. CNI deals with > UTS namespaces when a task gets a container rootfs, and also > properly configures a container hostname, so this isolator > deals with the remainin case, which is when the task doesn't > have a container image. In this case, we will retain the host's > hostname configuration but protect it from the task by placing > the task in a private UTS namespace. > > > Diffs > ----- > > src/CMakeLists.txt 21fb47e29dd0b19681690b8de5261c68b574a7c8 > src/Makefile.am 155338673e1c23a2cfeab39bdf3ebe14568bfebc > src/slave/containerizer/mesos/containerizer.cpp > cd1e9ae8b8925cb97396dde22b6a3eb63ab65536 > src/slave/containerizer/mesos/isolators/namespaces/uts.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/namespaces/uts.cpp PRE-CREATION > src/tests/containerizer/isolator_tests.cpp > bdc3619f18cd65f609d967a036be0467c1e62896 > > > Diff: https://reviews.apache.org/r/65391/diff/2/ > > > Testing > ------- > > sudo make check (Fedora 27) > > > Thanks, > > James Peach > >
