----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196536 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/docker.cpp Line 975 (original), 976 (patched) <https://reviews.apache.org/r/65382/#comment276219> s/in this case/in which case/ src/slave/containerizer/docker.cpp Line 976 (original), 977 (patched) <https://reviews.apache.org/r/65382/#comment276220> s/not error/safe to skip/ src/slave/containerizer/docker.cpp Lines 979 (patched) <https://reviews.apache.org/r/65382/#comment276218> Do we return a "failed" container termination here? AFAICT, we return `None` on `wait` in this case? src/slave/containerizer/docker.cpp Lines 1040-1048 (patched) <https://reviews.apache.org/r/65382/#comment276221> I moved this comment block to #1027 src/slave/containerizer/docker.cpp Lines 1041 (patched) <https://reviews.apache.org/r/65382/#comment276222> s/, this/. This/ src/slave/containerizer/docker.cpp Lines 1047 (patched) <https://reviews.apache.org/r/65382/#comment276223> s/reboots/reboots or restarts/ ? src/slave/containerizer/docker.cpp Lines 1052-1054 (patched) <https://reviews.apache.org/r/65382/#comment276224> LOG(WARNING) << "Failed to connect to executor '" << executor.id << "' of framework " << framework.id Can we log the SocketError here as well? - Vinod Kone On Jan. 30, 2018, 3:42 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65382/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 3:42 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-8125 > https://issues.apache.org/jira/browse/MESOS-8125 > > > Repository: mesos > > > Description > ------- > > Reaped Docker executor only when it can be connected. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp f1d7d3e6afa119a6a24b054dcaa5ee68dbea965d > > > Diff: https://reviews.apache.org/r/65382/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
