> On Jan. 27, 2018, 1:25 a.m., Gaston Kleiman wrote: > > src/tests/mesos.hpp > > Lines 3177 (patched) > > <https://reviews.apache.org/r/65315/diff/1/?file=1946019#file1946019line3177> > > > > Would `PermissiveObjectApprover` be a better name?
I actually realized that the test class is unnecessary, since we already have an `AcceptingObjectApprover` in common code. Updated the patch accordingly, LMK what you think. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/#review196380 ----------------------------------------------------------- On Jan. 31, 2018, 2:52 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65315/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 2:52 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone. > > > Bugs: MESOS-8469 > https://issues.apache.org/jira/browse/MESOS-8469 > > > Repository: mesos > > > Description > ------- > > Removed a redundant authorization helper class from the tests. > > > Diffs > ----- > > src/tests/mesos.cpp d751b2e9c635eb6a5039678de426467176cda908 > > > Diff: https://reviews.apache.org/r/65315/diff/2/ > > > Testing > ------- > > Testing details in the child review. > > > Thanks, > > Greg Mann > >
