> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 8903 (patched) > > <https://reviews.apache.org/r/65045/diff/5/?file=1946628#file1946628line8903> > > > > Do we need this, or does framework registration after master failover > > prompt an offer?
You're right that framework registration prompts an offer, but I've seen rare cases where it didn't, resulting in a flaky test, e.g. as reported in MESOS-8490. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65045/#review196621 ----------------------------------------------------------- On Jan. 25, 2018, 2:10 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65045/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2018, 2:10 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > Tested correct operation handling during master failover. > > > Diffs > ----- > > src/tests/master_tests.cpp d01f3fbdd688ddd31fb0c777f973928f5b5fa5e7 > > > Diff: https://reviews.apache.org/r/65045/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
