----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review196648 -----------------------------------------------------------
src/slave/containerizer/mesos/main.cpp Lines 40-50 (patched) <https://reviews.apache.org/r/65465/#comment276370> TODO: Comment in here why it is necessary; and also comment where we create the job object too. - Andrew Schwartzmeyer On Feb. 1, 2018, 11:57 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65465/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2018, 11:57 a.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The Windows OS deletes the job object created in the agent process when > the agent dies, because no other process holds a handle to it (despite > processes being assigned to the job object). While this is > counter-intuitive, it is the observed behavior. So in order for recovery > to succeed, the containerizer must also hold an otherwise unused handle > to its job object to keep it alive in the kernel, and available for > recovery to find. > > > Diffs > ----- > > src/slave/containerizer/mesos/main.cpp > a53ccd68bf975d919f9d1f920cf3fa74d4e43f24 > > > Diff: https://reviews.apache.org/r/65465/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
