----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/ -----------------------------------------------------------
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Repository: mesos Description ------- On Windows, we make all file handles non-inheritable by default. Therefore when creating a `Subprocess::FD` for a subprocess to inherit a file descriptor, we have to explicitly make it inheritable. This was already happening as a side-effect of `os::dup` for `IO::DUPLICATED` file descriptors, but not for `IO::OWNED`. Both, however, are meant to be inherited. Diffs ----- 3rdparty/libprocess/src/subprocess.cpp 785e2e1083d115d25fffde2df74ed8bc1726511c Diff: https://reviews.apache.org/r/65469/diff/1/ Testing ------- Thanks, Andrew Schwartzmeyer
