-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65394/#review196727
-----------------------------------------------------------




src/checks/checks_runtime.hpp
Lines 32-66 (patched)
<https://reviews.apache.org/r/65394/#comment276535>

    Overall, I like these abstractions. I think Plain, Docker, and Nested are 
all immediately understandable.
    
    Nit: indentation (just run clang-format on the file please :).



src/checks/checks_types.hpp
Lines 31-77 (patched)
<https://reviews.apache.org/r/65394/#comment276536>

    Again, I like these abstractions. This is going to clean up the health 
check code significantly.
    
    Nit: clang-format!


- Andrew Schwartzmeyer


On Jan. 30, 2018, 2:05 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65394/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2018, 2:05 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and 
> Gaston Kleiman.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is in preparation of another patch that will refactor the
> health check code using these types.
> 
> 
> Diffs
> -----
> 
>   src/checks/checks_runtime.hpp PRE-CREATION 
>   src/checks/checks_types.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65394/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Reply via email to