----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review196734 -----------------------------------------------------------
src/checks/checker_process.cpp Lines 523-525 (original), 523-526 (patched) <https://reviews.apache.org/r/65419/#comment276562> I knew it looked funny. src/checks/checker_process.cpp Line 527 (original), 528-535 (patched) <https://reviews.apache.org/r/65419/#comment276563> I'm not quite following this. Why do we always push `command.value()` then? src/checks/checker_process.cpp Lines 535-537 (original), 543-547 (patched) <https://reviews.apache.org/r/65419/#comment276564> Can you explain why this was changed a little more? Maybe an example would help. - Andrew Schwartzmeyer On Jan. 30, 2018, 2:12 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65419/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 2:12 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Joseph Wu. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The docker executor was wrapping the docker exec command around with > `sh -c ""`, which was causing quoting issues, especially on Windows. > Now, the comamnd health check simply runs `docker exec` without any > wrapping. > > > Diffs > ----- > > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65419/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >
