----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65491/#review196751 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Lines 487 (patched) <https://reviews.apache.org/r/65491/#comment276589> Do we need to keep the prefix? src/resource_provider/storage/provider.cpp Lines 1828 (patched) <https://reviews.apache.org/r/65491/#comment276590> One line apart. src/tests/storage_local_resource_provider_tests.cpp Lines 2551-2559 (patched) <https://reviews.apache.org/r/65491/#comment276592> No need to set up the master flags since we don't create a framework waiting for offers in this test. - Chun-Hung Hsiao On Feb. 2, 2018, 10:40 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65491/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 10:40 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann. > > > Bugs: MESOS-8539 > https://issues.apache.org/jira/browse/MESOS-8539 > > > Repository: mesos > > > Description > ------- > > Added metrics for CSI plugin terminations. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 163ce7f9bcc740525ad185d854c9bacd5e0937de > src/tests/storage_local_resource_provider_tests.cpp > 85eaef877cb3d62aed0eb2bd5adfba8007c3ee76 > > > Diff: https://reviews.apache.org/r/65491/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
