----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65503/#review196858 -----------------------------------------------------------
Looks good, couple of questions: (1) Doesn't this need to be part of the installation? I think you need to update the autotools and cmake builds? (2) Do we need to update LICENSE to include this new sub-component? - Benjamin Mahler On Feb. 4, 2018, 9:12 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65503/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2018, 9:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8486 > https://issues.apache.org/jira/browse/MESOS-8486 > > > Repository: mesos > > > Description > ------- > > This library extends the properties of the tables provided by Bootstrap. > Link to the library repo: https://github.com/wenzhixin/bootstrap-table. > Bootstrap Table is licensed under the The MIT License. > > > Diffs > ----- > > src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION > src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION > src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION > support/mesos-style.py 1b34ea2d9afa8f17b545841cea7a6853a6e18144 > > > Diff: https://reviews.apache.org/r/65503/diff/1/ > > > Testing > ------- > > Tested in the dependent review request /r/65346/ > > > Thanks, > > Armand Grillet > >
