----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65399/#review197027 -----------------------------------------------------------
Ship it! Ship It! - Akash Gupta On Feb. 7, 2018, 7:20 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65399/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2018, 7:20 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6713 > https://issues.apache.org/jira/browse/MESOS-6713 > > > Repository: mesos > > > Description > ------- > > Instead of setting this flag unconditionally when we create a job > object, this patch abstracts it to the the function > `set_job_kill_on_close_limit(pid_t)` so that users can choose how to tie > job object lifetimes together. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > ec935209fc1532ebe087ac20933c99eed393506d > > > Diff: https://reviews.apache.org/r/65399/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
