----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65541/ -----------------------------------------------------------
(Updated Feb. 7, 2018, 5:36 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Added some consideration for the `Resources` object, still has some edge cases that I haven't figured out how to work around yet (see a TODO). Bugs: MESOS-2487 https://issues.apache.org/jira/browse/MESOS-2487 Repository: mesos Description ------- This is an attempt to use the MessageDifferencer class (introduced in protobuf 3.0) to replace our handwritten protobuf equality operators. This patch currently: * Ignores style rules (mostly). * Has TODOs to deal with the Resources and Attributes classes, which have their own wrappers and may need to be special-cased. * Only deals with non-versioned protobufs at the moment. * Can be made faster by making the MessageDifferencer into a `static thread_local` object guarded by a Once. Diffs (updated) ----- include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2 Diff: https://reviews.apache.org/r/65541/diff/2/ Changes: https://reviews.apache.org/r/65541/diff/1-2/ Testing ------- Thanks, Joseph Wu