-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65518/#review197206
-----------------------------------------------------------




src/docker/executor.cpp
Lines 277 (patched)
<https://reviews.apache.org/r/65518/#comment277339>

    s/never returns though/to never return although/



src/docker/executor.cpp
Lines 280 (patched)
<https://reviews.apache.org/r/65518/#comment277340>

    when can this be None()?



src/docker/executor.cpp
Lines 288 (patched)
<https://reviews.apache.org/r/65518/#comment277336>

    Add a LOG line here?



src/docker/executor.cpp
Lines 289 (patched)
<https://reviews.apache.org/r/65518/#comment277341>

    s/lambda/lambda;/



src/docker/executor.cpp
Lines 530 (patched)
<https://reviews.apache.org/r/65518/#comment277338>

    why not call `reaped` directly? sounds like `reaped` does a bunch of 
necessary cleanup that you are skipping by calling `_reaped`?



src/docker/executor.cpp
Line 490 (original), 535 (patched)
<https://reviews.apache.org/r/65518/#comment277343>

    shouldn't we return here if `terminated` already is set in case the `run` 
returns after `reapedContainer` is called?


- Vinod Kone


On Feb. 9, 2018, 1:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65518/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2018, 1:03 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8488
>     https://issues.apache.org/jira/browse/MESOS-8488
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to a Docker issue (https://github.com/moby/moby/issues/33820),
> Docker daemon will fail to catch a container exit, i.e., the container
> process has already exited but the command `docker ps` shows the
> container still running, this will lead to the "docker run" command
> that we execute in Docker executor never returns, and it will also
> cause the `docker stop` command takes no effect, i.e., it will return
> without error but `docker ps` shows the container still running, so
> the task will stuck in `TASK_KILLING` state.
> 
> To workaround this Docker issue, in this patch we made Docker executor
> reaps the container process directly so Docker executor will be notified
> once the container process exits.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a 
> 
> 
> Diff: https://reviews.apache.org/r/65518/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to