-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65504/#review197286
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Lines 4920-4924 (original), 4919-4928 (patched)
<https://reviews.apache.org/r/65504/#comment277412>

    I think this should be 
    
    ```
    bool launchExecutor = true;
    if (task.has_executor()) {
     launchExecutor = isLaunchExecutor(task.executor().executor_id(), 
framework, slave);
     if (launchExecutor) {
       addExecutor(task.executor(), framework, slave);
       consumed += task.executor().resources()
     }
     
    } 
    
    ```
    
    otherwise, the log line below says we are launching a command task on an 
existing executor which is wrong.


- Vinod Kone


On Feb. 5, 2018, 2:49 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65504/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2018, 2:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, and Vinod Kone.
> 
> 
> Bugs: MESOS-1720
>     https://issues.apache.org/jira/browse/MESOS-1720
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By setting a new field `launch_executor` in the RunTask(Group)Message,
> the master is able to control the executor creation on the agent.
> 
> Also refactored `addTask()` logic. Added two new functions:
> `isTaskLaunchExecutor()` checks if a task needs to launch executor;
> `addExecutor()` adds executor to the framework and slave.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 
>   src/master/master.cpp d7d22866f7a4eb87bd8949efafc97e828e7d4b94 
> 
> 
> Diff: https://reviews.apache.org/r/65504/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Reply via email to