----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/#review197331 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 12, 2018, 3:35 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65617/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2018, 3:35 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and John Kordich. > > > Bugs: MESOS-6715 > https://issues.apache.org/jira/browse/MESOS-6715 > > > Repository: mesos > > > Description > ------- > > Fixed Windows-specific issues (absolute path, subprocess invocation) > to allow Hadoop Fetcher Plugin to run properly. > > > Diffs > ----- > > src/hdfs/hdfs.cpp f9fc1cbb5556d4c1b2ee3a103b4f3bb4fe1d7589 > > > Diff: https://reviews.apache.org/r/65617/diff/1/ > > > Testing > ------- > > Full test pass on both Linux and Windows. > > Additionally, on Windows platform: > > ``` > [==========] Running 3 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 3 tests from HadoopFetcherPluginTest > [ RUN ] HadoopFetcherPluginTest.FetchExistingFile > > C:\Users\jeffcof\AppData\Local\Temp\UrtxvI>if "version" == "version" (exit 0 ) > [ OK ] HadoopFetcherPluginTest.FetchExistingFile (235 ms) > [ RUN ] HadoopFetcherPluginTest.FetchNonExistingFile > > C:\Users\jeffcof\AppData\Local\Temp\YJVcTA>if "version" == "version" (exit 0 ) > [ OK ] HadoopFetcherPluginTest.FetchNonExistingFile (217 ms) > [ RUN ] HadoopFetcherPluginTest.InvokeFetchByName > > C:\Users\jeffcof\AppData\Local\Temp\wsQjH1>if "version" == "version" (exit 0 ) > [ OK ] HadoopFetcherPluginTest.InvokeFetchByName (217 ms) > [----------] 3 tests from HadoopFetcherPluginTest (674 ms total) > > [----------] Global test environment tear-down > [==========] 3 tests from 1 test case ran. (12790 ms total) > [ PASSED ] 3 tests. > ``` > > > Thanks, > > Jeff Coffler > >
