-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65570/#review197359
-----------------------------------------------------------



Can you add tests for this in a subsequent review please?


src/slave/slave.hpp
Line 434 (original), 442 (patched)
<https://reviews.apache.org/r/65570/#comment277482>

    s/at it to make it can be/to it so that it can be/



src/slave/slave.hpp
Line 435 (original), 443 (patched)
<https://reviews.apache.org/r/65570/#comment277483>

    s/, so/. So/



src/slave/slave.cpp
Line 1043 (original), 1044 (patched)
<https://reviews.apache.org/r/65570/#comment277493>

    can you fix the naming to be consistent with below comments?



src/slave/slave.cpp
Lines 1075 (patched)
<https://reviews.apache.org/r/65570/#comment277484>

    `containerInfo`



src/slave/slave.cpp
Lines 1078-1087 (patched)
<https://reviews.apache.org/r/65570/#comment277495>

    kill this. see below.



src/slave/slave.cpp
Lines 1089-1091 (patched)
<https://reviews.apache.org/r/65570/#comment277497>

    kill this.



src/slave/slave.cpp
Lines 1109-1111 (patched)
<https://reviews.apache.org/r/65570/#comment277488>

    I don't think we need this check. We want to show non PV directories too in 
the UI.



src/slave/slave.cpp
Lines 1113 (patched)
<https://reviews.apache.org/r/65570/#comment277491>

    executorRunPath



src/slave/slave.cpp
Lines 1120 (patched)
<https://reviews.apache.org/r/65570/#comment277490>

    s/executorVolumePath/executorDirectoryPath/



src/slave/slave.cpp
Lines 1131 (patched)
<https://reviews.apache.org/r/65570/#comment277492>

    taskDirectoryPath



src/slave/slave.cpp
Lines 1157-1167 (patched)
<https://reviews.apache.org/r/65570/#comment277494>

    kill this.



src/slave/slave.cpp
Lines 1196-1198 (patched)
<https://reviews.apache.org/r/65570/#comment277496>

    kill this.



src/slave/slave.cpp
Lines 1219-1221 (patched)
<https://reviews.apache.org/r/65570/#comment277498>

    kill this.



src/slave/slave.cpp
Lines 1231 (patched)
<https://reviews.apache.org/r/65570/#comment277499>

    taskDirectoryPath


- Vinod Kone


On Feb. 10, 2018, 2:59 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65570/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2018, 2:59 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8565
>     https://issues.apache.org/jira/browse/MESOS-8565
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Attached/detached volume directory for task which has volume specified.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 
> 
> 
> Diff: https://reviews.apache.org/r/65570/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to