----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197426 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On Feb. 13, 2018, 3:52 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65637/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 3:52 p.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-8577 > https://issues.apache.org/jira/browse/MESOS-8577 > > > Repository: mesos > > > Description > ------- > > Previously, if `attachContainerOutput()` returned http error for > `LAUNCH_NESTED_CONTAINER_SESSION` call, we didn't destroy the nested > container. From the point of view of API user, if > `LAUNCH_NESTED_CONTAINER_SESSION` returns an error, then no nested > container should be in `RUNNING` state. This patch fixes the API > issue by destroying a nested container on http errors and failures > of `attachContainerOutput()`. > > > Diffs > ----- > > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > > > Diff: https://reviews.apache.org/r/65637/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
