----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65570/#review197483 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 1113-1132 (patched) <https://reviews.apache.org/r/65570/#comment277651> Should we have a helper or refactor upper codes to avoid duplicating these part of code? src/slave/slave.cpp Lines 1223-1232 (patched) <https://reviews.apache.org/r/65570/#comment277652> ditto. - Gilbert Song On Feb. 13, 2018, 7:09 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65570/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 7:09 p.m.) > > > Review request for mesos, Gilbert Song and Vinod Kone. > > > Bugs: MESOS-8565 > https://issues.apache.org/jira/browse/MESOS-8565 > > > Repository: mesos > > > Description > ------- > > Attached/detached volume directory for task which has volume specified. > > > Diffs > ----- > > src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 > src/slave/slave.cpp f98f37321872d090176b7cc50873fc3c627773f5 > > > Diff: https://reviews.apache.org/r/65570/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
