> On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 7307 (original), 7351 (patched) > > <https://reviews.apache.org/r/65591/diff/2/?file=1961540#file1961540line7353> > > > > Do we plan to support resource providers with info (so not the > > agent-default resources), but without an ID? > > > > Line 7470 indicates that we don't.
Added `CHECK`s here as well. > On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 7516 (patched) > > <https://reviews.apache.org/r/65591/diff/2/?file=1961540#file1961540line7672> > > > > It doesnt look like `operation_` is used after this line. Can we revert > > to inlining the creation of the operation? Like the comment above indicated this should have updated `operations`, fixed the code. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197652 ----------------------------------------------------------- On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65591/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 3:12 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8382 > https://issues.apache.org/jira/browse/MESOS-8382 > > > Repository: mesos > > > Description > ------- > > This patch adds explicit tracking of resource providers to the master > process. While we already had explicitly send resource provider > information in e.g., `UpdateSlaveMessage`, we only stored that > information aggregated over the full agent in the master up to now. > > > Diffs > ----- > > src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f > src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 > src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d > > > Diff: https://reviews.apache.org/r/65591/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
