-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64211/
-----------------------------------------------------------
(Updated Feb. 16, 2018, 10:54 p.m.)
Review request for mesos, Benjamin Bannier and Kevin Klues.
Changes
-------
Rebased patch and improved `Testing Done`.
Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240
Repository: mesos
Description
-------
An update of the discarded review /r/52543.
Works with Autotools and CMake.
Diffs (updated)
-----
CMakeLists.txt 6702f02245e3867c06bbd9efbbf4e3b961a7d9aa
cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e
configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
docs/configuration/cmake.md 1e34657ea55fa324f65f865f7d0a67084c6719d9
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
src/python/cli_new/CMakeLists.txt PRE-CREATION
src/python/cli_new/tests/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/64211/diff/10/
Changes: https://reviews.apache.org/r/64211/diff/9-10/
Testing (updated)
-------
Testing done on Fedora 25.
For Autotools:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ ../configure --enable-new-cli --disable-java --disable-python
$ make check
```
For CMake:
```
$ ./bootstrap
$ mkdir build
$ cd build
$ cmake .. -DENABLE_NEW_CLI=1
$ cmake --build . -- -j16
$ ./src/mesos
Mesos CLI
Usage:
mesos (-h | --help)
mesos --version
mesos <command> [<args>...]
Options:
-h --help Show this screen.
--version Show version info.
Commands:
agent Interacts with the Mesos agents
config Interacts with the Mesos CLI configuration file
task Interacts with the tasks running in a Mesos cluster
See 'mesos help <command>' for more information on a specific command.
$ cmake --build . --target tests -- -j16
$ ctest -R CLI
Test project /home/agrillet/apache-mesos/build
Start 4: CLITests
1/1 Test #4: CLITests ......................... Passed 3.63 sec
100% tests passed, 0 tests failed out of 1
```
Checked that the the CLI tests were run, that the content of the directory
`build/src/cli` was as expected, and that `build/src/mesos` was correctly
running.
Thanks,
Armand Grillet
