-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65574/
-----------------------------------------------------------
(Updated Feb. 20, 2018, 5:19 p.m.)
Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu.
Changes
-------
Added more commentary.
Bugs: MESOS-6838 and MESOS-8512
https://issues.apache.org/jira/browse/MESOS-6838
https://issues.apache.org/jira/browse/MESOS-8512
Repository: mesos
Description
-------
The primary change in this patch is that `create_process` now enables
inheritance for the `pipe` handles passed before starting the child
process. This is required, otherwise the child process will behave
incorrectly (for example, it will write to `stdout` but that will go
nowhere, as the redirection silently failed). After the process is
created, inheritance is disabled to prevent further calls to
`create_process` from inheriting the wrong handles.
The `std::tuple<os::WindowsFD, ...>` type was changed to a
`std::array<os::WindowsFD, 3>` as it is significantly easier to work
with (it supports iteration).
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/shell.hpp
542039c31f94eda1af121335b12edf9b83725ae5
Diff: https://reviews.apache.org/r/65574/diff/2/
Changes: https://reviews.apache.org/r/65574/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
