----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65733/#review197900 -----------------------------------------------------------
Bad patch! Reviews applied: [65733, 65727, 64387, 65615, 65127, 65419, 65396, 65395, 65394, 65393] Failed command: python support/apply-reviews.py -n -r 65615 Error: 2018-02-21 15:56:34 URL:https://reviews.apache.org/r/65615/diff/raw/ [10438/10438] -> "65615.patch" [1] error: patch failed: src/tests/mesos.hpp:2170 error: src/tests/mesos.hpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/21713/console - Mesos Reviewbot On Feb. 21, 2018, 2:19 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65733/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 2:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Joseph Wu. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_ > DockerHealthStatusChange` test was flaky on Windows, because > the docker executor manually reaps the container exit code in > case that `docker run` fails to get the exit code. This logic > doesn't work on Windows, since the process might not be visible to > the container host machine, causing `TASK_FAILED` to get sent. By > removing the reaping logic on Windows, the test is much more reliable. > > > Diffs > ----- > > src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc > > > Diff: https://reviews.apache.org/r/65733/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
