----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197942 -----------------------------------------------------------
Fix it, then Ship it! src/checks/checker_process.cpp Lines 577-578 (patched) <https://reviews.apache.org/r/65419/#comment278170> `cbegin() / cend()` please. - Alexander Rukletsov On Feb. 21, 2018, 2:07 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65419/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2018, 2:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, and Joseph Wu. > > > Bugs: MESOS-4812 and MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-4812 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > The docker executor was wrapping the docker exec command around with > `sh -c ""`, which was causing quoting issues, especially on Windows. > Now, the comamnd health check simply runs `docker exec` without any > wrapping. > > > Diffs > ----- > > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > > > Diff: https://reviews.apache.org/r/65419/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >
