----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/#review197980 -----------------------------------------------------------
Bad review! Error: Circular dependency detected for review 65462. Please fix the 'depends_on' field. - Mesos Reviewbot Windows On Feb. 6, 2018, 9:40 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65461/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2018, 9:40 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Provide new overload of 'ProcessBase::route()'. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/logging.hpp > f9997677d69d54f5723d4fc0a495008d3ce11cc5 > 3rdparty/libprocess/include/process/process.hpp > 8661706cb058efb26f5bfbcc84972f9930d3670f > 3rdparty/libprocess/include/process/profiler.hpp > 2991dd2033d68802a813de91babb47679c807aa0 > 3rdparty/libprocess/src/metrics/metrics.cpp > f79541853b4c826014ee969633345c3d51520ecf > > > Diff: https://reviews.apache.org/r/65461/diff/3/ > > > Testing > ------- > > It is a common pattern in libprocess to have a single function serving as > endpoint that handles both authenticated and non-authenticated requests, > providing `None()` as a default parameter in non-authenticated contexts. > > This patch adds an overload to `ProcessBase::route()` implementing that so > that it does not need to be re-implemented in each individual process. > > > Thanks, > > Benno Evers > >
