-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65395/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 1:44 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston
Kleiman.
Changes
-------
Rebased + Alex's feedback.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
Refactored health check code to separate the logic for each check
type and runtime (Plain/Docker/Nested). Now the matrix of different
possiblilites is cleanly enumerated, making it easier to add
future health checks, such as the ones for Windows.
Diffs (updated)
-----
src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837
src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d
src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28
src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f
src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685
src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3
src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc
src/launcher/default_executor.cpp 8720dada8bc6ca66f9e0fec6dc265eda3dcc7407
src/launcher/executor.cpp caa2cfcf90ca727c612b4051f389367e85238522
Diff: https://reviews.apache.org/r/65395/diff/6/
Changes: https://reviews.apache.org/r/65395/diff/5-6/
Testing
-------
make check
Thanks,
Akash Gupta
