----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65795/#review198259 -----------------------------------------------------------
Ship it! This address the first point of MESOS-8586 by warning the user that a patch (or patches) were skipped when applying a review chain if they were already submitted. Note that the second point is left purposefully unaddressed, as the user will be warned it was already submitted, and then can use `git cherry-pick` to backport the patch. - Andrew Schwartzmeyer On Feb. 24, 2018, 5:36 p.m., Shubham Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65795/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2018, 5:36 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8586 > https://issues.apache.org/jira/browse/MESOS-8586 > > > Repository: mesos > > > Description > ------- > > This commit emits a warning when a chain skips submitted patches so > that the user is aware they were ignored. > > > Diffs > ----- > > support/apply-reviews.py 9fc1579f732609dac1b19ff5862f374e71e6cb53 > > > Diff: https://reviews.apache.org/r/65795/diff/1/ > > > Testing > ------- > > Test done. > > command: ./support/apply-reviews.py -c -r 65397 > output: Warning: Review 65397 has already been applied > > > Thanks, > > Shubham Kumar > >
