----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65798/#review198262 -----------------------------------------------------------
Ship it! I'll fix the remaining stuff. src/cli/CMakeLists.txt Line 17 (original), 17 (patched) <https://reviews.apache.org/r/65798/#comment278357> Hm, I thought we'd deleted this. I'll fix it. src/cli/execute.cpp Lines 982 (patched) <https://reviews.apache.org/r/65798/#comment278356> Nit: Comments should end with a period. (I'll fix it when I commit.) - Andrew Schwartzmeyer On Feb. 24, 2018, 7:22 p.m., Sachin Paryani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65798/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2018, 7:22 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8607 > https://issues.apache.org/jira/browse/MESOS-8607 > > > Repository: mesos > > > Description > ------- > > This change allows for the mesos-execute cli framework to work on Windows. > The change was to print an appropriate error message without the calling > getuid which doesn't exist in Windows. > > > Diffs > ----- > > src/cli/CMakeLists.txt 06d9e62bc28bf82d594d9deda0b7e1d962b1dbef > src/cli/execute.cpp 221d65f4b498c4831e24ff34bd54b18a7364457a > > > Diff: https://reviews.apache.org/r/65798/diff/1/ > > > Testing > ------- > > Successfully built the mesos-execute cli from source and executed on Windows > environment using the following command: > ./src/mesos-execute --master=192.168.56.1:5050 --name="simple-test" > --command=notepad > > > Thanks, > > Sachin Paryani > >
