----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65799/#review198264 -----------------------------------------------------------
src/master/CMakeLists.txt Lines 19-20 (original), 17-18 (patched) <https://reviews.apache.org/r/65799/#comment278359> Reminder for myself: I might add a comment noting that the master is not for production use on Windows, just for testing. src/master/main.cpp Lines 210 (patched) <https://reviews.apache.org/r/65799/#comment278358> Hm, we had a `NOTE: Because of os::shell` here, must have overwritten the file when playing with Git earlier. I'll fix it. - Andrew Schwartzmeyer On Feb. 24, 2018, 7:19 p.m., Sachin Paryani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65799/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2018, 7:19 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-5820 > https://issues.apache.org/jira/browse/MESOS-5820 > > > Repository: mesos > > > Description > ------- > > The change allows for the mesos-master executable to work on Windows. > The change was to remove the part of the code for that utilizes the > ip_discovery_command flag if the build is Windows and replaced with > an appropriate error message. > > > Diffs > ----- > > src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 > src/master/main.cpp 8cb52d0c452ab3c328eea80aa56f1c984de372e9 > > > Diff: https://reviews.apache.org/r/65799/diff/1/ > > > Testing > ------- > > Successfully built the master and then started the mesos-master executable. > The following command was used: > ./src/mesos-master --registry='in_memory' --webui_dir=../src/webui > > > Thanks, > > Sachin Paryani > >
