----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65806/#review198304 -----------------------------------------------------------
Does this need to depend on the previous renaming patch? Makes cherry-picking a little messier - Benjamin Mahler On Feb. 27, 2018, 12:45 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65806/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 12:45 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-8604 > https://issues.apache.org/jira/browse/MESOS-8604 > > > Repository: mesos > > > Description > ------- > > When calculating the quota headroom, we failed to consider > ancestor's reservation allocated to the child. This leads > to under-estimation of available headroom and excessive > resources being set aside for headroom. See MESOS-8604. > > This patches fixes this issue by counting ancestor's reservation > allocated to the child as allocated-reservation even though > the child itself has no reservation. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 80e0a347d6641c922cf7c62bef220ff5c8864597 > > > Diff: https://reviews.apache.org/r/65806/diff/1/ > > > Testing > ------- > > make check > Dedicated test in #65807 > > > Thanks, > > Meng Zhu > >
