----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65807/#review198308 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp Lines 5592-5593 (patched) <https://reviews.apache.org/r/65807/#comment278436> maybe parens around (total reservations - allocated reservations) or just showing the unallocated reservations would be clearer? ``` // Required headroom: quota(cpus:1;mem:1024) // // Available headroom = total resources (cpus:3;mem:3072) - // allocated resources (cpus:1;mem:1024) - // unallocated reservations (cpus:0;mem:0) // = (cpus:2;mem:2048) ``` Note some ':' characters were missing here as well. src/tests/hierarchical_allocator_tests.cpp Lines 5597 (patched) <https://reviews.apache.org/r/65807/#comment278437> This would produce a negative? I think you mean available - required? src/tests/hierarchical_allocator_tests.cpp Lines 5608-5614 (patched) <https://reviews.apache.org/r/65807/#comment278434> s/.get()./->/ here src/tests/hierarchical_allocator_tests.cpp Lines 5613-5614 (patched) <https://reviews.apache.org/r/65807/#comment278435> ``` EXPECT_EQ(agentResources, Resources::sum(allocation->resources.at(NO_QUOTA_ROLE))); ``` Or: ``` EXPECT_EQ( agentResources, Resources::sum(allocation->resources.at(NO_QUOTA_ROLE))); ``` - Benjamin Mahler On Feb. 27, 2018, 12:45 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65807/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 12:45 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-8604 > https://issues.apache.org/jira/browse/MESOS-8604 > > > Repository: mesos > > > Description > ------- > > This test ensures that resources can be correctly allocated > in the presence of quota when ancestor reservations are > allocated to child. Specifically, it checks that ancestor > reservations allocated to child are counted by the quota > headroom calculation. See MESOS-8604. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 42dc6ac5e281bb0cdb938106fd3f12324e9e6330 > > > Diff: https://reviews.apache.org/r/65807/diff/1/ > > > Testing > ------- > > > Thanks, > > Meng Zhu > >
