> On Feb. 15, 2018, 7:23 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 578-585 (patched) > > <https://reviews.apache.org/r/65246/diff/4/?file=1953485#file1953485line578> > > > > I'm puzzled about what's going on here, why do we need to stream the > > data through javascript and create a file hyperlink and click it? Why > > didn't we have to do this for the sandbox download links?
Because I wanted to set the name of the file downloaded which is not necessary with the sandbox download links. We cannot use the HTML attribute `download` as browsers do not honor the download attribute suggested filename for cross origin requests. After the last revision, the name of the files will be something like `mesos-master.Mac.Armand.log.INFO.20180226-105655` which is not optimal (no file extension, too much information in the name). - Armand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review197631 ----------------------------------------------------------- On Feb. 27, 2018, 3:31 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65246/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 3:31 p.m.) > > > Review request for mesos, Benjamin Mahler, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-8454 > https://issues.apache.org/jira/browse/MESOS-8454 > > > Repository: mesos > > > Description > ------- > > Adds a new button to download the logs in addition to the ability to > view them. Does not display the buttons if the master or agent does not > have an external log file or a log directory. Displays the correct logs, > i.e. if you are on a non-leading master you will get the logs of that > master and not the leading master. > > Regarding the architectural choices, `HomeCtrl` is now similar to the > other controllers with an update function called when the state changes. > > > Diffs > ----- > > src/webui/master/static/agent.html 908d01d1d28f2a4fc595b581fa16515c5be1410a > src/webui/master/static/home.html df3eef61eb9564dbdfc3d138ecfd18e85f747f11 > src/webui/master/static/js/controllers.js > 59665869dbea77c00740e42f2590473181dfe2fe > > > Diff: https://reviews.apache.org/r/65246/diff/5/ > > > Testing > ------- > > Tested using Google Chrome 64.0.3282.119. > > Created an High Availability Mode Mesos cluster locally: > ``` > $ zkServer start > $ bash mesos-master.sh --port='5061' --zk='zk://127.0.0.1:2181/mesos' > --work_dir='/tmp/master1' --quorum=1 > --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' > --log_dir='/tmp/master1-log' > $ bash mesos-master.sh --port='5062' --zk='zk://127.0.0.1:2181/mesos' > --work_dir='/tmp/master2' --quorum=1 > --webui_dir='/Users/Armand/Code/apache-mesos/src/webui' > --log_dir='/tmp/master2-log' > $ bash mesos-agent.sh --port='5051' --master='zk://127.0.0.1:2181/mesos' > --work_dir='/tmp/agent1' --log_dir='/tmp/agent1-log' > ``` > Tested the download and streaming features on the home and agents Web UI > endpoints, from both `http://localhost:5061/` and `http://localhost:5062/`. > > New UI (masters): >  > > New UI (agents): >  > > > Thanks, > > Armand Grillet > >
