----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review198502 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp Lines 637 (patched) <https://reviews.apache.org/r/59989/#comment278647> Extra new line here. 3rdparty/stout/tests/protobuf_tests.cpp Lines 675-676 (patched) <https://reviews.apache.org/r/59989/#comment278648> Do you want to use a raw string literal here to avoid all the escaping? (6) from here: http://en.cppreference.com/w/cpp/language/string_literal - Benjamin Mahler On Feb. 28, 2018, 11:28 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59989/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2018, 11:28 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Chun-Hung Hsiao, > and Zhitao Li. > > > Bugs: MESOS-7656 > https://issues.apache.org/jira/browse/MESOS-7656 > > > Repository: mesos > > > Description > ------- > > Added a test `ProtobufTest.JsonifyMap`. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > be35ad0d1e16501df67752a1818f79751419a43d > > > Diff: https://reviews.apache.org/r/59989/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
