----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198547 -----------------------------------------------------------
src/common/resources.cpp Lines 936 (patched) <https://reviews.apache.org/r/65838/#comment278733> s/Resource_DiskInfo_Source_Type_Name/Resource::DiskInfo::Source::Type_Name/ We usually call the `Type_Name` functions this way. src/common/resources.cpp Lines 943 (patched) <https://reviews.apache.org/r/65838/#comment278734> Ditto. src/v1/resources.cpp Lines 959 (patched) <https://reviews.apache.org/r/65838/#comment278735> Ditto. src/v1/resources.cpp Lines 966 (patched) <https://reviews.apache.org/r/65838/#comment278736> Ditto. - Chun-Hung Hsiao On March 2, 2018, 10:46 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65838/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 10:46 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Updated validation of 'RAW' and 'BLOCK' disk resources. > > > Diffs > ----- > > src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33 > src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9 > > > Diff: https://reviews.apache.org/r/65838/diff/2/ > > > Testing > ------- > > `make check` > `sudo make check` > > > Thanks, > > Benjamin Bannier > >
