----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63991/#review198557 -----------------------------------------------------------
Fix it, then Ship it! src/common/protobuf_utils.hpp Lines 167 (patched) <https://reviews.apache.org/r/63991/#comment278751> This function generates `UpdateOperationStatus` events for frameworks. The master will only send an operation status update to a framework if `operationId` is set, so it should be a required field, i.e., `const OperationID& operationId`. - Gaston Kleiman On March 2, 2018, 12:06 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63991/ > ----------------------------------------------------------- > > (Updated March 2, 2018, 12:06 a.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu. > > > Bugs: MESOS-8190 > https://issues.apache.org/jira/browse/MESOS-8190 > > > Repository: mesos > > > Description > ------- > > Added helpers to create and forward offer operation updates. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 9a940db188436b9c5a39b0637cb4c15ee2ab5266 > src/common/protobuf_utils.cpp f516091e9208552488c154f34adde6f20d3413bf > src/master/master.hpp 1fadbe61f774e8ca9926af4e39b3d6c8e24fe5df > src/master/master.cpp 9cea7bb6a6ee8bf5f4226d07111bcfa6f5d3a88c > > > Diff: https://reviews.apache.org/r/63991/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
