----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65898/#review198613 -----------------------------------------------------------
PASS: Mesos patch 65898 was successfully built and tested. Reviews applied: `['65811', '65812', '65898']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65898 - Mesos Reviewbot Windows On March 5, 2018, 7:30 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65898/ > ----------------------------------------------------------- > > (Updated March 5, 2018, 7:30 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > This patch is a refactor from `launch.cpp`, intended for porting and > splitting OS-specific launch logic (initially `installResourceLimits`, > `prepareMounts` and `chroot`) into different OS-based subclasses. > There is no change in business logic from the counterparts in > `launch.cpp`. > > > Diffs > ----- > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/slave/containerizer/mesos/launch/helper.hpp PRE-CREATION > src/slave/containerizer/mesos/launch/helper.cpp PRE-CREATION > src/slave/containerizer/mesos/launch/linux_helper.hpp PRE-CREATION > src/slave/containerizer/mesos/launch/linux_helper.cpp PRE-CREATION > src/slave/containerizer/mesos/launch/posix_helper.hpp PRE-CREATION > src/slave/containerizer/mesos/launch/posix_helper.cpp PRE-CREATION > src/slave/containerizer/mesos/launch/windows_helper.hpp PRE-CREATION > src/slave/containerizer/mesos/launch/windows_helper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65898/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
