----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65928/#review198710 -----------------------------------------------------------
Patch looks great! Reviews applied: [65928] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 6, 2018, 3:24 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65928/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 3:24 p.m.) > > > Review request for mesos, Benjamin Mahler and Till Toenshoff. > > > Bugs: MESOS-8503 > https://issues.apache.org/jira/browse/MESOS-8503 > > > Repository: mesos > > > Description > ------- > > Shows a clickable link if a framework has more than three roles. On > click all its roles will be displayed with the possibility to hide them > again. The roles are now displayed in their alphabetical order to make > it easier to find one among many. All previous functionalities remain. > > > Diffs > ----- > > src/Makefile.am 84753794eca822ab251200cccb907b328c849fb7 > src/webui/master/static/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 > src/webui/master/static/agent_framework.html > 06f1697aac91c70f5c0350159ffd26958a8436f1 > src/webui/master/static/framework.html > 82f6b279a9416d147fcfab094a326d67d0951dcc > src/webui/master/static/framework_roles.html PRE-CREATION > src/webui/master/static/frameworks.html > d37c6137b638a27e5bd0f70f08733d81550b3ace > src/webui/master/static/js/controllers.js > 66a4f2955a88fa44c3e5c717e9ce6b680050cc34 > > > Diff: https://reviews.apache.org/r/65928/diff/1/ > > > Testing > ------- > > Manual testing. > >  > > > Thanks, > > Armand Grillet > >
