----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65930/#review198722 -----------------------------------------------------------
Patch looks great! Reviews applied: [65930] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 6, 2018, 4:57 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65930/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 4:57 p.m.) > > > Review request for mesos, Greg Mann, Jason Lai, Quinn Leng, and Vinod Kone. > > > Bugs: MESOS-8641 > https://issues.apache.org/jira/browse/MESOS-8641 > > > Repository: mesos > > > Description > ------- > > https://reviews.apache.org/r/61262 added heartbeat support to > event stream, but the implementation could send a `HEARTBEAT` > event before `SUBSCRIBED` event, which changed previous behavior. > > This patch fixed the issue by starting heartbeater only after > `SUBSCRIBED` event is sent. > > > Diffs > ----- > > src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad > > > Diff: https://reviews.apache.org/r/65930/diff/1/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
