----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review198759 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp Lines 583 (patched) <https://reviews.apache.org/r/65899/#comment278999> why is the explicit delete needed here? was it not being cleaned up previously? - Eric Chung On March 5, 2018, 7:31 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65899/ > ----------------------------------------------------------- > > (Updated March 5, 2018, 7:31 a.m.) > > > Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, > James Peach, and Zhitao Li. > > > Bugs: MESOS-8257 > https://issues.apache.org/jira/browse/MESOS-8257 > > > Repository: mesos > > > Description > ------- > > Removed launch actions in `src/slave/containerizer/mesos/launch.cpp` > and replaced with those in a `MesosContainerLauncherHelper` subclass > instead. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 75b7eaf9cd62d6b5f02896175168b651f4517e12 > > > Diff: https://reviews.apache.org/r/65899/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
