----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65721/#review198782 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On March 6, 2018, 9:05 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65721/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 9:05 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and > Joseph Wu. > > > Bugs: MESOS-8599 > https://issues.apache.org/jira/browse/MESOS-8599 > > > Repository: mesos > > > Description > ------- > > This is necessary to enable the Ninja build. This was not previously > fixed because we have not yet used Ninja on Windows. The same pattern > is used for other imported targets. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e > > > Diff: https://reviews.apache.org/r/65721/diff/2/ > > > Testing > ------- > > Built with Ninja on Windows in 17 minutes, versus 21 minutes using the VS > generator (both builds completely from scratch). > > No more Ninja warnings (only expected compiler warnings). > > > Thanks, > > Andrew Schwartzmeyer > >
