-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review198805
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/tests/lambda_tests.cpp
Lines 18-19 (patched)
<https://reviews.apache.org/r/65310/#comment279051>

    I don't think these includes are necessary?
    
    I do see a few missing, however:
    
    <list>
    <string>
    <utility>
    <vector>
    
    <stout/hashmap.hpp>


- Greg Mann


On March 6, 2018, 10:11 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65310/
> -----------------------------------------------------------
> 
> (Updated March 6, 2018, 10:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
>     https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the abstractions `lambda::zip` and `lambda::zipto` which
> provides a functionality similar to python's  `zip()` call.
> 
> This patch supersedes the stalled review
> https://reviews.apache.org/r/63292/.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp 
> c9212be27b45da45f15371689f2aabf18c98657b 
>   3rdparty/stout/tests/lambda_tests.cpp 
> 11b034306b11b95efa9bcd9811c5145ad39314a5 
> 
> 
> Diff: https://reviews.apache.org/r/65310/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to