----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65955/#review198816 -----------------------------------------------------------
PASS: Mesos patch 65955 was successfully built and tested. Reviews applied: `['65955']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65955 - Mesos Reviewbot Windows On March 7, 2018, 6:45 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65955/ > ----------------------------------------------------------- > > (Updated March 7, 2018, 6:45 p.m.) > > > Review request for mesos, Jie Yu, James Peach, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > This patch fixes three new "possible loss of data" implicit conversion > warnings by using `static_cast` to the LHS type. > > > Diffs > ----- > > src/docker/docker.cpp bb81c4d68df95b0ccb2a0830e651c75f4493752e > src/slave/containerizer/fetcher.cpp > a49411b7bac2d5a50a75d0b802842c2f61fe58c6 > src/slave/containerizer/mesos/containerizer.cpp > a61ed5bb4f60ec63aebd6bdabbc9a4b01235623e > > > Diff: https://reviews.apache.org/r/65955/diff/1/ > > > Testing > ------- > > Ninja build on Linux annd VS build on Windows. Warnings gone AFAICT. > > We really need to turn on conversion warnings on the Linux build. Do any of > you know how? Until we do, I'm hesitant to add -Werror to the Windows build. > > > Thanks, > > Andrew Schwartzmeyer > >